fix: set taxes and totals before validating subcontracting transaction by karm1000 · Pull Request #3782 · resilient-tech/india-compliance

karm1000 · 2025-11-07T09:52:42Z

Summary by CodeRabbit

Refactor
- Tax initialization now runs earlier and only once, preventing duplicate calculations.
Bug Fixes / Tests
- total_taxes now shows 0.0 (not blank) for subcontracting orders with unregistered entities and for material receipt stock entries.
Tests
- Updated ITC-04 export expectations: adjusted an item's reported value from 0.0 to 200.0.

coderabbitai · 2025-11-07T09:53:01Z

Walkthrough

Moves tax initialization to the start of subcontracting transaction validation, removes a duplicate tax initialization, and updates tests and ITC-04 test data to reflect adjusted numeric totals and txval values.

Changes

Cohort / File(s)	Summary
Subcontracting validation reorder `india_compliance/gst_india/overrides/subcontracting_transaction.py`	Selected `field_map` and invoked `CustomTaxController(doc, field_map).set_taxes_and_totals()` at the start of `validate(doc, method=None)`; removed the duplicate call later in the same function.
Test expectation updates `india_compliance/gst_india/overrides/test_subcontracting_transaction.py`	Updated tests to expect `total_taxes == 0.0` instead of `None` for unregistered company subcontracting order and for stock entry material receipt scenarios.
ITC-04 test data adjustment `india_compliance/gst_india/utils/itc_04/test_itc_04_export.py`	Adjusted test fixture expected `txval` for the SRM item under `m2jw` from `0.0` to `200.0`, updating assertions against generated ITC-04 JSON payload.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as validate(doc)
    participant FieldMap as field_map selection
    participant TaxCtrl as CustomTaxController
    participant Remaining as remaining validation logic

    Note over Caller,FieldMap: Reordered — taxes set early
    Caller->>FieldMap: determine field_map
    FieldMap->>TaxCtrl: CustomTaxController(doc, field_map)
    TaxCtrl->>TaxCtrl: set_taxes_and_totals()
    TaxCtrl-->>Caller: taxes & totals set
    Caller->>Remaining: continue validate (checks, updates, return)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Check validate() for assumptions about taxes being set later in the function.
Verify updated tests cover edge cases (unregistered company, material receipt).
Confirm the ITC-04 txval change matches source fixture intent.

Suggested labels

backport version-15-hotfix

Suggested reviewers

ljain112

Poem

🐰 I hopped in early, set taxes with care,

removed the twin step that lingered there.
Tests now hum zero, numbers neat and true,
a carrot cheer for validation anew. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: moving tax initialization to occur before validation in the subcontracting transaction logic.
Linked Issues check	✅ Passed	Changes in validate() now execute tax initialization upfront before validation, and updated test expectations reflect 0.0 for total_taxes, addressing the objective in #3777 to update tax fields in backend even when ineligible.
Out of Scope Changes check	✅ Passed	All changes are directly related to the objective: restructuring tax initialization in subcontracting validation and updating test data/expectations to match the new tax calculation behavior.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8884f56 and 9df3998.

📒 Files selected for processing (1)

india_compliance/gst_india/utils/itc_04/test_itc_04_export.py (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-06-25T08:19:02.607Z

Learnt from: karm1000
Repo: resilient-tech/india-compliance PR: 3354
File: india_compliance/gst_india/report/summary_of_itc_availed/summary_of_itc_availed.py:278-281
Timestamp: 2025-06-25T08:19:02.607Z
Learning: In the Summary of ITC Availed report (india_compliance/gst_india/report/summary_of_itc_availed/summary_of_itc_availed.py), the summary dictionaries created by get_initial_summary() are never empty - they always contain tax field keys (igst_amount, cgst_amount, sgst_amount, cess_amount) with 0 values, so checking for empty dictionaries is unnecessary.

Applied to files:

india_compliance/gst_india/utils/itc_04/test_itc_04_export.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Codacy Static Code Analysis
GitHub Check: Python Unit Tests
GitHub Check: Mergify Merge Protections

🔇 Additional comments (1)

india_compliance/gst_india/utils/itc_04/test_itc_04_export.py (1)

58-58: LGTM! Test data correctly updated to reflect the fix.

The change from 0.0 to 200.0 for the txval field correctly reflects the new behavior where taxes and totals are now calculated even for transactions that may not have been considered eligible before. This aligns with the PR objective to ensure backend updates of grand total and tax fields in stock entries.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ljain112 · 2025-11-07T12:01:44Z

@karm1000 resolve test cases

… for zero

…TC-04 export test

codecov · 2025-11-10T12:51:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.59%. Comparing base (c312d10) to head (9df3998).
⚠️ Report is 182 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3782   +/-   ##
========================================
  Coverage    69.59%   69.59%           
========================================
  Files          182      182           
  Lines        17967    17967           
========================================
  Hits         12504    12504           
  Misses        5463     5463

Files with missing lines	Coverage Δ
.../gst_india/overrides/subcontracting_transaction.py	`84.78% <100.00%> (ø)`
...india/overrides/test_subcontracting_transaction.py	`97.33% <100.00%> (ø)`
...iance/gst_india/utils/itc_04/test_itc_04_export.py	`100.00% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ljain112 · 2026-02-06T06:27:03Z

@Mergifyio backport version-15-hotfix

mergify · 2026-02-06T06:27:07Z

backport version-15-hotfix

✅ Backports have been created

Details

#3960 fix: set taxes and totals before validating subcontracting transaction (backport #3782) has been created for branch version-15-hotfix

…tfix/pr-3782 fix: set taxes and totals before validating subcontracting transaction (backport #3782)

karm1000 requested a review from ljain112 November 7, 2025 09:52

ljain112 reviewed Nov 7, 2025

View reviewed changes

Comment thread india_compliance/gst_india/overrides/subcontracting_transaction.py Outdated

fix: set taxes and totals before validating subcontracting transaction

7cea4ab

karm1000 force-pushed the set-values-even-if-not-eligible branch from 9d5e3d0 to 7cea4ab Compare November 7, 2025 11:41

karm1000 requested a review from ljain112 November 7, 2025 11:42

karm1000 added 2 commits November 7, 2025 18:09

fix(test): update subcontracting order total taxes assertion to check…

8884f56

… for zero

fix: update transaction value for subcontracted transaction item in I…

9df3998

…TC-04 export test

vorasmit merged commit 1f2d9f7 into resilient-tech:develop Nov 11, 2025
13 checks passed

karm1000 mentioned this pull request Nov 11, 2025

Revert "fix: set taxes and totals before validating subcontracting transaction" #3783

Closed

ljain112 added the backport version-15-hotfix label Feb 6, 2026

mergify Bot mentioned this pull request Feb 6, 2026

fix: set taxes and totals before validating subcontracting transaction (backport #3782) #3960

Merged

mergify Bot added a commit that referenced this pull request Feb 6, 2026

Merge pull request #3960 from resilient-tech/mergify/bp/version-15-ho…

b6c561f

…tfix/pr-3782 fix: set taxes and totals before validating subcontracting transaction (backport #3782)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: set taxes and totals before validating subcontracting transaction#3782

fix: set taxes and totals before validating subcontracting transaction#3782
vorasmit merged 3 commits intoresilient-tech:developfrom
karm1000:set-values-even-if-not-eligible

karm1000 commented Nov 7, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Nov 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

ljain112 commented Nov 7, 2025

Uh oh!

codecov Bot commented Nov 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

ljain112 commented Feb 6, 2026

Uh oh!

mergify Bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

karm1000 commented Nov 7, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

ljain112 commented Nov 7, 2025

Uh oh!

codecov Bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

ljain112 commented Feb 6, 2026

Uh oh!

mergify Bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

karm1000 commented Nov 7, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Nov 7, 2025 •

edited

Loading

codecov Bot commented Nov 10, 2025 •

edited

Loading

mergify Bot commented Feb 6, 2026 •

edited

Loading